pep/poezio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
poezio/plugins/simple_notify.py

40 lines
1.6 KiB
Python
Raw Normal View History

Remove useless stuff from the simple_notify plugin
2012-05-05 16:26:54 +00:00
from plugin import BasePlugin
And add the missing files.
2012-01-10 15:32:29 +00:00
from xhtml import clean_text, get_body_from_message_stanza
Improve the simple_notify plugin and the daemon to execute a command to clean the notification and to execute the remote commands through sh -c, letting us use pipes and redirections. Also adds the highlight event for plugin, and make the simple_notify plugin use it as well.
2012-07-02 23:59:25 +00:00
from timed_events import DelayedEvent
Make the Executor class reliable. Plugins do not need to escape the command arguments or remove the line breaks and care about how the will get parsed anymore, they just need to pass a list of args. Do not spawn an additional shell, for more clarity, simplicity and possibly security.
2012-10-22 15:14:21 +00:00
import shlex
And add the missing files.
2012-01-10 15:32:29 +00:00
class Plugin(BasePlugin):
def init(self):
self.add_event_handler('private_msg', self.on_private_msg)
self.add_event_handler('conversation_msg', self.on_conversation_msg)
Improve the simple_notify plugin and the daemon to execute a command to clean the notification and to execute the remote commands through sh -c, letting us use pipes and redirections. Also adds the highlight event for plugin, and make the simple_notify plugin use it as well.
2012-07-02 23:59:25 +00:00
self.add_event_handler('highlight', self.on_highlight)
And add the missing files.
2012-01-10 15:32:29 +00:00
def on_private_msg(self, message, tab):
fro = message['from']
self.do_notify(message, fro)
Improve the simple_notify plugin and the daemon to execute a command to clean the notification and to execute the remote commands through sh -c, letting us use pipes and redirections. Also adds the highlight event for plugin, and make the simple_notify plugin use it as well.
2012-07-02 23:59:25 +00:00
def on_highlight(self, message, tab):
fro = message['from'].resource
self.do_notify(message, fro)
And add the missing files.
2012-01-10 15:32:29 +00:00
def on_conversation_msg(self, message, tab):
fro = message['from'].bare
self.do_notify(message, fro)
def do_notify(self, message, fro):
body = clean_text(get_body_from_message_stanza(message))
if not body:
return
Make the Executor class reliable. Plugins do not need to escape the command arguments or remove the line breaks and care about how the will get parsed anymore, they just need to pass a list of args. Do not spawn an additional shell, for more clarity, simplicity and possibly security.
2012-10-22 15:14:21 +00:00
command_str = self.config.get('command', '').strip()
if not command_str:
And add the missing files.
2012-01-10 15:32:29 +00:00
self.core.information('No notification command was provided in the configuration file', 'Warning')
return
Make the Executor class reliable. Plugins do not need to escape the command arguments or remove the line breaks and care about how the will get parsed anymore, they just need to pass a list of args. Do not spawn an additional shell, for more clarity, simplicity and possibly security.
2012-10-22 15:14:21 +00:00
command = [arg % {'body': body.replace('\n', ' '), 'from': fro} for arg in shlex.split(command_str)]
self.core.exec_command(command)
after_command_str = self.config.get('after_command', '').strip()
if not after_command_str:
Improve the simple_notify plugin and the daemon to execute a command to clean the notification and to execute the remote commands through sh -c, letting us use pipes and redirections. Also adds the highlight event for plugin, and make the simple_notify plugin use it as well.
2012-07-02 23:59:25 +00:00
return
Make the Executor class reliable. Plugins do not need to escape the command arguments or remove the line breaks and care about how the will get parsed anymore, they just need to pass a list of args. Do not spawn an additional shell, for more clarity, simplicity and possibly security.
2012-10-22 15:14:21 +00:00
after_command = [arg % {'body': body.replace('\n', ' '), 'from': fro} for arg in shlex.split(after_command_str)]
delayed_event = DelayedEvent(self.config.get('delay', 1), self.core.exec_command, after_command)
Improve the simple_notify plugin and the daemon to execute a command to clean the notification and to execute the remote commands through sh -c, letting us use pipes and redirections. Also adds the highlight event for plugin, and make the simple_notify plugin use it as well.
2012-07-02 23:59:25 +00:00
self.core.add_timed_event(delayed_event)
Reference in a new issue Copy permalink