pep/poezio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Properly yield an error on /add without arguments

Browse source
This commit is contained in:
Florent Le Coz 2015-05-26 14:28:34 +02:00
parent 03c2d2974a
commit 0c8fe4da30
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/tabs/rostertab.py
View file

@ -619,10 +619,13 @@ class RosterInfoTab(Tab):
Add the specified JID to the roster, and set automatically
accept the reverse subscription
"""
jid = safeJID(safeJID(args[0]).bare)
if not jid:
if args is None:
self.core.information('No JID specified', 'Error')
return
jid = safeJID(safeJID(args[0]).bare)
if not str(jid):
self.core.information('The provided JID (%s) is not valid' % (args[0],), 'Error')
return
if jid in roster and roster[jid].subscription in ('to', 'both'):
return self.core.information('Already subscribed.', 'Roster')
roster.add(jid)