pep/poezio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use SHA-2 (SHA-512) to store the certificate fingerprint instead of SHA-1

Browse source 
Because SHA-1 is not really relevant anymore.
Too bad it's significantly longer and tiring to check, even if that is
to be expected.
This commit is contained in:
mathieui 2014-10-08 12:55:22 +02:00
parent dc4f9cc35a
commit 8d2408c169
No known key found for this signature in database
GPG key ID: C59F84CEEFD616E3
2 changed files with 28 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
doc/source/configuration.rst
View file

@ -62,8 +62,11 @@ and certificate validation.
**Default value:** ``[empty]`` **Default value:** ``[empty]``
The fingerprint of the SSL certificate as a hexadecimal string, you should The SHA-2 fingerprint of the SSL certificate as a hexadecimal string,
not touch it, except if know what you are doing. you should not touch it, except if know what you are doing.
.. note:: the fingerprint was previously stored in SHA-1, and has been
silently upgraded to SHA-2 if the SHA-1 still matched.
ciphers ciphers

35
src/core/handlers.py
View file

@ -8,7 +8,7 @@ log = logging.getLogger(__name__)
import curses import curses
import ssl import ssl
import time import time
from hashlib import sha1 from hashlib import sha1, sha512
from gettext import gettext as _ from gettext import gettext as _
from sleekxmpp import InvalidJID from sleekxmpp import InvalidJID
@ -1069,16 +1069,27 @@ def validate_ssl(self, pem):
config.set_and_save('certificate', cert) config.set_and_save('certificate', cert)
der = ssl.PEM_cert_to_DER_cert(pem) der = ssl.PEM_cert_to_DER_cert(pem)
digest = sha1(der).hexdigest().upper() sha1_digest = sha1(der).hexdigest().upper()
found_cert = ':'.join(i + j for i, j in zip(digest[::2], digest[1::2])) sha1_found_cert = ':'.join(i + j for i, j in zip(sha1_digest[::2], sha1_digest[1::2]))
sha2_digest = sha512(der).hexdigest().upper()
sha2_found_cert = ':'.join(i + j for i, j in zip(sha2_digest[::2], sha2_digest[1::2]))
if cert: if cert:
if found_cert == cert: if sha1_found_cert == cert:
log.debug('Cert %s OK', found_cert) log.debug('Cert %s OK', sha1_found_cert)
log.debug('Current hash is SHA-1, moving to SHA-2 (%s)',
sha2_found_cert)
config.set_and_save('certificate', sha2_found_cert)
return
elif sha2_found_cert == cert:
log.debug('Cert %s OK', sha2_found_cert)
return return
else: else:
saved_input = self.current_tab().input saved_input = self.current_tab().input
log.debug('\nWARNING: CERTIFICATE CHANGED old: %s, new: %s\n', cert, found_cert) log.debug('\nWARNING: CERTIFICATE CHANGED old: %s, new: %s\n', cert, sha2_found_cert)
input = windows.YesNoInput(text="WARNING! Server certificate has changed, accept? (y/n) (%s)" % found_cert) self.information('New certificate found (sha-2 hash:'
' %s)\nPlease validate or abort' % sha2_found_cert,
'Warning')
input = windows.YesNoInput(text="WARNING! Server certificate has changed, accept? (y/n)")
self.current_tab().input = input self.current_tab().input = input
input.resize(1, self.current_tab().width, self.current_tab().height-1, 0) input.resize(1, self.current_tab().width, self.current_tab().height-1, 0)
input.refresh() input.refresh()
@ -1089,16 +1100,16 @@ def validate_ssl(self, pem):
self.current_tab().input = saved_input self.current_tab().input = saved_input
self.paused = False self.paused = False
if input.value: if input.value:
self.information('Setting new certificate: old: %s, new: %s' % (cert, found_cert), 'Info') self.information('Setting new certificate: old: %s, new: %s' % (cert, sha2_found_cert), 'Info')
log.debug('Setting certificate to %s', found_cert) log.debug('Setting certificate to %s', sha2_found_cert)
if not config.silent_set('certificate', found_cert): if not config.silent_set('certificate', sha2_found_cert):
self.information(_('Unable to write in the config file'), 'Error') self.information(_('Unable to write in the config file'), 'Error')
else: else:
self.information('You refused to validate the certificate. You are now disconnected', 'Info') self.information('You refused to validate the certificate. You are now disconnected', 'Info')
self.xmpp.disconnect() self.xmpp.disconnect()
else: else:
log.debug('First time. Setting certificate to %s', found_cert) log.debug('First time. Setting certificate to %s', sha2_found_cert)
if not config.silent_set('certificate', found_cert): if not config.silent_set('certificate', sha2_found_cert):
self.information(_('Unable to write in the config file'), 'Error') self.information(_('Unable to write in the config file'), 'Error')
def _composing_tab_state(tab, state): def _composing_tab_state(tab, state):