pep/poezio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix the resource duplication when reconnecting while auto_reconnect is true.

Browse source 
The problem is that core.legitimate_disconnect is set to True in the
on_connecting callback which is called before the session_end for some
reasons. on_connecting sets core.legitimate_disconnect back to False so
session_end thinks we've been disconnected and connects automagically
adding a resource and thus duplicating everything.

Moving the reset of legitimate_disconnect to the on_connected callback
fixes the problem.
This commit is contained in:
Eijebong 2017-04-11 13:42:51 +02:00 committed by mathieui
parent bc08858b8a
commit a07c87bcbe
2 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
poezio/core/core.py
View file

@ -199,7 +199,6 @@ class Core(object):
self.key_func.update(key_func)
# Add handlers
self.xmpp.add_event_handler('connecting', self.handler.on_connecting)
self.xmpp.add_event_handler('connected', self.handler.on_connected)
self.xmpp.add_event_handler('connection_failed', self.handler.on_failed_connection)
self.xmpp.add_event_handler('disconnected', self.handler.on_disconnected)

5
poezio/core/handlers.py
View file

@ -989,11 +989,6 @@ class HandlerCore:
Remote host responded, but we are not yet authenticated
"""
self.core.information("Connected to server.", 'Info')
def on_connecting(self, event):
"""
Just before we try to connect to the server
"""
self.core.legitimate_disconnect = False
def on_session_start(self, event):