fix: do not use re.match() on existing Pattern objects

this is duplicating effort and going through re._compile once more
approximately slows down the log parsing by 15%
This commit is contained in:
mathieui 2021-06-26 14:53:17 +02:00
parent 1456566f10
commit e5b4f7ab0d

View file

@ -82,10 +82,10 @@ def parse_log_line(msg: str, jid: str = '') -> Optional[LogItem]:
:param jid: jid (for error logging)
:returns: The LogItem or None on error
"""
match = re.match(MESSAGE_LOG_RE, msg)
match = MESSAGE_LOG_RE.match(msg)
if match:
return LogMessage(*match.groups())
match = re.match(INFO_LOG_RE, msg)
match = INFO_LOG_RE.match(msg)
if match:
return LogInfo(*match.groups())
log.debug('Error while parsing %ss logs: “%s', jid, msg)