Merge branch 'master' into develop

This commit is contained in:
Lance Stout 2012-10-14 17:35:37 -07:00
commit 7c485c6a8b
5 changed files with 72 additions and 80 deletions

View file

@ -54,13 +54,9 @@ class FeatureSTARTTLS(BasePlugin):
return False
elif not self.xmpp.use_tls:
return False
elif self.xmpp.ssl_support:
else:
self.xmpp.send(features['starttls'], now=True)
return True
else:
log.warning("The module tlslite is required to log in" + \
" to some servers, and has not been found.")
return False
def _handle_starttls_proceed(self, proceed):
"""Restart the XML stream when TLS is accepted."""

View file

@ -47,13 +47,18 @@ class XEP_0280(BasePlugin):
register_stanza_plugin(Iq, stanza.CarbonEnable)
register_stanza_plugin(Iq, stanza.CarbonDisable)
register_stanza_plugin(stanza.ReceivedCarbon,
self.xmpp['xep_0297'].stanza.Forwarded)
register_stanza_plugin(stanza.SentCarbon,
self.xmpp['xep_0297'].stanza.Forwarded)
def plugin_end(self):
self.xmpp.remove_handler('Carbon Received')
self.xmpp.remove_handler('Carbon Sent')
self.xmpp.plugin['xep_0030'].del_feature(feature='urn:xmpp:carbons:1')
self.xmpp.plugin['xep_0030'].del_feature(feature='urn:xmpp:carbons:2')
def session_bind(self, jid):
self.xmpp.plugin['xep_0030'].add_feature('urn:xmpp:carbons:1')
self.xmpp.plugin['xep_0030'].add_feature('urn:xmpp:carbons:2')
def _handle_carbon_received(self, msg):
self.xmpp.event('carbon_received', msg)

View file

@ -11,54 +11,54 @@ from sleekxmpp.xmlstream import ElementBase
class ReceivedCarbon(ElementBase):
name = 'received'
namespace = 'urn:xmpp:carbons:1'
namespace = 'urn:xmpp:carbons:2'
plugin_attrib = 'carbon_received'
interfaces = set(['carbon_received'])
is_extension = True
def get_carbon_received(self):
return self.parent()['forwarded']['stanza']
return self['forwarded']['stanza']
def del_carbon_received(self):
del self.parent()['forwarded']['stanza']
del self['forwarded']['stanza']
def set_carbon_received(self, stanza):
self.parent()['forwarded']['stanza'] = stanza
self['forwarded']['stanza'] = stanza
class SentCarbon(ElementBase):
name = 'sent'
namespace = 'urn:xmpp:carbons:1'
namespace = 'urn:xmpp:carbons:2'
plugin_attrib = 'carbon_sent'
interfaces = set(['carbon_sent'])
is_extension = True
def get_carbon_sent(self):
return self.parent()['forwarded']['stanza']
return self['forwarded']['stanza']
def del_carbon_sent(self):
del self.parent()['forwarded']['stanza']
del self['forwarded']['stanza']
def set_carbon_sent(self, stanza):
self.parent()['forwarded']['stanza'] = stanza
self['forwarded']['stanza'] = stanza
class PrivateCarbon(ElementBase):
name = 'private'
namespace = 'urn:xmpp:carbons:1'
namespace = 'urn:xmpp:carbons:2'
plugin_attrib = 'carbon_private'
interfaces = set()
class CarbonEnable(ElementBase):
name = 'enable'
namespace = 'urn:xmpp:carbons:1'
namespace = 'urn:xmpp:carbons:2'
plugin_attrib = 'carbon_enable'
interfaces = set()
class CarbonDisable(ElementBase):
name = 'disable'
namespace = 'urn:xmpp:carbons:1'
namespace = 'urn:xmpp:carbons:2'
plugin_attrib = 'carbon_disable'
interfaces = set()

View file

@ -662,7 +662,7 @@ class ElementBase(object):
full_attrib = attrib
attrib_lang = ('%s|' % attrib).split('|')
attrib = attrib_lang[0]
lang = attrib_lang[1] or ''
lang = attrib_lang[1] or None
kwargs = {}
if lang and attrib in self.lang_interfaces:
@ -738,7 +738,7 @@ class ElementBase(object):
full_attrib = attrib
attrib_lang = ('%s|' % attrib).split('|')
attrib = attrib_lang[0]
lang = attrib_lang[1] or ''
lang = attrib_lang[1] or None
kwargs = {}
if lang and attrib in self.lang_interfaces:
@ -824,7 +824,7 @@ class ElementBase(object):
full_attrib = attrib
attrib_lang = ('%s|' % attrib).split('|')
attrib = attrib_lang[0]
lang = attrib_lang[1] or ''
lang = attrib_lang[1] or None
kwargs = {}
if lang and attrib in self.lang_interfaces:
@ -862,7 +862,7 @@ class ElementBase(object):
del plugin[full_attrib]
del self.plugins[(attrib, None)]
else:
del self.plugins[(attrib, lang)]
del self.plugins[(attrib, plugin['lang'])]
self.loaded_plugins.remove(attrib)
try:
self.xml.remove(plugin.xml)

View file

@ -58,9 +58,6 @@ WAIT_TIMEOUT = 0.1
#: a GIL increasing this value can provide better performance.
HANDLER_THREADS = 1
#: Flag indicating if the SSL library is available for use.
SSL_SUPPORT = True
#: The time in seconds to delay between attempts to resend data
#: after an SSL error.
SSL_RETRY_DELAY = 0.5
@ -117,9 +114,6 @@ class XMLStream(object):
"""
def __init__(self, socket=None, host='', port=0):
#: Flag indicating if the SSL library is available for use.
self.ssl_support = SSL_SUPPORT
#: Most XMPP servers support TLSv1, but OpenFire in particular
#: does not work well with it. For OpenFire, set
#: :attr:`ssl_version` to use ``SSLv23``::
@ -506,7 +500,7 @@ class XMLStream(object):
self.reconnect_delay = delay
return False
if self.use_ssl and self.ssl_support:
if self.use_ssl:
log.debug("Socket Wrapped for SSL")
if self.ca_certs is None:
cert_policy = ssl.CERT_NONE
@ -535,7 +529,7 @@ class XMLStream(object):
log.debug("Connecting to %s:%s", domain, self.address[1])
self.socket.connect(self.address)
if self.use_ssl and self.ssl_support:
if self.use_ssl:
try:
self.socket.do_handshake()
except (Socket.error, ssl.SSLError):
@ -823,7 +817,6 @@ class XMLStream(object):
If the handshake is successful, the XML stream will need
to be restarted.
"""
if self.ssl_support:
log.info("Negotiating TLS")
log.info("Using SSL version: %s", str(self.ssl_version))
if self.ca_certs is None:
@ -853,6 +846,7 @@ class XMLStream(object):
if not self.event_handled('ssl_invalid_chain'):
self.disconnect(self.auto_reconnect, send_close=False)
else:
self._der_cert = self.socket.getpeercert(binary_form=True)
self.event('ssl_invalid_chain', direct=True)
return False
@ -872,9 +866,6 @@ class XMLStream(object):
self.set_socket(self.socket)
return True
else:
log.warning("Tried to enable TLS, but ssl module not found.")
return False
def _cert_expiration(self, event):
"""Schedule an event for when the TLS certificate expires."""