From 2c764b7c7d542449c0e02a172cce3d434af46125 Mon Sep 17 00:00:00 2001 From: Emmanuel Gil Peyrot Date: Fri, 4 Dec 2020 23:44:43 +0100 Subject: [PATCH 1/5] DOAP: List the correct versions and support status --- doap.xml | 424 ++++++++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 339 insertions(+), 85 deletions(-) diff --git a/doap.xml b/doap.xml index e8c3b07a..0de5591c 100644 --- a/doap.xml +++ b/doap.xml @@ -77,446 +77,670 @@ - unknown + complete + 2.11.0 + 1.0 - unknown + complete + 2.2 + 1.0 - unknown + complete + 2.0 + 1.0 - unknown + complete + 1.2 + 1.0 - unknown + complete + 1.7 + 1.0 + The XEP is deprecated, we might remove support for it at some point. - unknown + complete + 1.6 + 1.0 - unknown + complete + 1.4 + 1.0 - unknown + complete + 2.5rc3 + 1.0 - unknown + complete + 1.2.1 + 1.0 - unknown + partial + 1.34.0 + 1.0 - unknown + complete + 2.0 + 1.0 - unknown + complete + 1.2 + 1.0 + The XEP is deprecated, we might remove support for it at some point. - unknown + complete + 1.2 + 1.0 - unknown + complete + 1.3.0 + 1.0 - unknown + complete + 1.2 + 1.0 - unknown + complete + 1.0 + 1.0 - unknown + partial + 1.19.0 + 1.0 - unknown + complete + 1.8.1 + 1.0 - unknown + complete + 1.5 + 1.0 + + + + + + complete + 1.0.1 + 1.2 - unknown + complete + 1.5.4 + 1.0 + This XEP is deprecated, but we have no plan to remove support for it. - unknown + complete + 2.4 + 1.0 - unknown + complete + 2.5 + 1.0 + This XEP is obsolete, we are considering removing support for it. - unknown + complete + 1.2 + 1.0 - unknown + complete + 1.9 + 1.0 - unknown + complete + 1.1 + 1.0 - unknown + complete + 1.1.4 + 1.0 - unknown + complete + 2.1 + 1.0 - unknown + complete + 1.0 + 1.0 + The XEP is deprecated, we might remove support for it at some point. - unknown + complete + 1.4 + 1.0 + This XEP is obsolete, we are considering removing support for it. - unknown + complete + 1.1 + 1.0 + + + + + + complete + 1.2 + 1.0 + The XEP is deprecated, we might remove support for it at some point. + + + + + + complete + 1.3 + 1.0 + The XEP is deprecated, we might remove support for it at some point. - unknown + complete + 1.1.1 + 1.0 - unknown + complete + 1.2.1 + 1.0 - unknown + complete + 1.3 + 1.0 - unknown + complete + 1.5.2 + 1.0 - unknown + complete + 1.3.0 + 1.0 - unknown + complete + 1.0.2 + 1.1 - unknown + complete + 1.0.1 + 1.0 - unknown + complete + 1.2 + 1.0 - unknown + complete + 1.2 + 1.0 + + + + + + complete + 2.0 + 1.1 - unknown + complete + 1.0 + 1.0 - unknown + complete + 1.1 + 1.0 - unknown + complete + 1.2.1 + 1.0 - unknown + complete + 1.1 + 1.0 - unknown + complete + 1.4.0 + 1.0 - unknown + complete + 0.14.0 + 1.0 - unknown + complete + 1.3 + 1.0 - unknown + complete + 0.3 + 1.0 - unknown + complete + 1.6 + 1.0 - unknown + complete + 2.0.1 + 1.0 - unknown + complete + 2.0 + 1.0 - unknown + complete + 2.0 + 1.0 - unknown + complete + 1.0 + 1.0 - unknown + complete + 1.0 + 1.0 - unknown + complete + 1.1 + 1.0 - unknown + complete + 1.0 + 1.0 - unknown + complete + 1.0 + 1.0 - unknown + complete + 0.7 + 1.0 - unknown + complete + 1.0 + 1.0 + This XEP is obsolete, we are considering removing support for it. - unknown + complete + 1.2 + 1.0 - unknown + complete + 1.1 + 1.2 - unknown + complete + 0.3 + 1.0 - unknown + complete + 1.1.1 + 1.0 - unknown + complete + 1.1 + 1.0 + This XEP is obsolete, we are considering removing support for it. - unknown + complete + 0.2 + 1.0 - unknown + complete + 0.13.2 + 1.0 - unknown + complete + 1.0 + 1.0 + + + + + + complete + 1.0.0 + 1.3.0 - unknown + complete + 0.1 + 1.0 + This XEP is obsolete, we are considering removing support for it. - unknown + complete + 1.2.0 + 1.0 - unknown + complete + 0.7.2 + 1.0 - unknown + complete + 1.0.2 + 1.0 - unknown + complete + 0.6 + 1.0 + This XEP has been retracted, we are considering removing support for it. - unknown - - - - - complete - NEXT + 0.5 + 1.0 + This XEP has been retracted, we are considering removing support for it. - unknown + complete + 0.5.1 + 1.1 + + + + + + complete + 0.4 + 1.2 + + + + + + complete + 0.3.0 + 1.2 + + + + + + complete + 0.1.1 + 1.5.0 + + + + + + complete + 1.0.0 + 1.2 @@ -528,14 +752,15 @@ - + complete + 0.6.1 NEXT - + complete 1.0.0 @@ -546,19 +771,39 @@ partial + 0.14.6 NEXT - unknown + complete + 0.2 + NEXT + + + + + + complete + 0.3.0 + 1.3.0 + + + + + + complete + 0.2.1 + 1.3.0 partial + 0.3.2 NEXT @@ -566,6 +811,7 @@ partial + 0.3.1 NEXT @@ -573,19 +819,23 @@ partial + 0.5.1 NEXT - unknown + complete + 0.1.0 + NEXT complete + 0.2.0 NEXT @@ -593,6 +843,7 @@ complete + 0.3.0 NEXT @@ -600,6 +851,7 @@ complete + 0.2.1 NEXT @@ -607,6 +859,7 @@ complete + 0.1.1 NEXT @@ -614,15 +867,16 @@ complete + 0.1.0 NEXT - 0.1.0 complete - 0.1.0 + 0.1.0 + NEXT From bb3c61f6e00696deab9137e262e5476d95b1a288 Mon Sep 17 00:00:00 2001 From: Emmanuel Gil Peyrot Date: Fri, 4 Dec 2020 23:57:50 +0100 Subject: [PATCH 2/5] DOAP: Add all of the releases --- doap.xml | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 94 insertions(+), 5 deletions(-) diff --git a/doap.xml b/doap.xml index 0de5591c..72259669 100644 --- a/doap.xml +++ b/doap.xml @@ -880,14 +880,103 @@ - From cc96e4a6e727c293e9baee28be287b25649473e0 Mon Sep 17 00:00:00 2001 From: Emmanuel Gil Peyrot Date: Fri, 4 Dec 2020 23:45:20 +0100 Subject: [PATCH 3/5] =?UTF-8?q?Plugins:=20Update=20the=20list=20to=20match?= =?UTF-8?q?=20what=E2=80=99s=20available?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Piugins for deprecated and obsolete XEPs aren’t loaded by default anymore. --- slixmpp/plugins/__init__.py | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/slixmpp/plugins/__init__.py b/slixmpp/plugins/__init__.py index 02ac3712..f37fdcfb 100644 --- a/slixmpp/plugins/__init__.py +++ b/slixmpp/plugins/__init__.py @@ -16,14 +16,14 @@ __all__ = [ 'xep_0009', # Jabber-RPC 'xep_0012', # Last Activity 'xep_0013', # Flexible Offline Message Retrieval - 'xep_0016', # Privacy Lists +# 'xep_0016', # Privacy Lists. Don’t automatically load 'xep_0020', # Feature Negotiation 'xep_0027', # Current Jabber OpenPGP Usage 'xep_0030', # Service Discovery 'xep_0033', # Extended Stanza Addresses 'xep_0045', # Multi-User Chat (Client) 'xep_0047', # In-Band Bytestreams - 'xep_0048', # Bookmarks +# 'xep_0048', # Legacy Bookmarks. Don’t automatically load 'xep_0049', # Private XML Storage 'xep_0050', # Ad-hoc Commands 'xep_0054', # vcard-temp @@ -31,17 +31,20 @@ __all__ = [ 'xep_0060', # Pubsub (Client) 'xep_0065', # SOCKS5 Bytestreams 'xep_0066', # Out of Band Data + 'xep_0070', # Verifying HTTP Requests via XMPP 'xep_0071', # XHTML-IM 'xep_0077', # In-Band Registration -# 'xep_0078', # Non-SASL auth. Don't automatically load +# 'xep_0078', # Non-SASL auth. Don’t automatically load 'xep_0079', # Advanced Message Processing 'xep_0080', # User Location 'xep_0082', # XMPP Date and Time Profiles 'xep_0084', # User Avatar 'xep_0085', # Chat State Notifications 'xep_0086', # Legacy Error Codes - 'xep_0091', # Legacy Delayed Delivery +# 'xep_0091', # Legacy Delayed Delivery. Don’t automatically load 'xep_0092', # Software Version +# 'xep_0095', # Legacy Stream Initiation. Don’t automatically load +# 'xep_0096', # Legacy SI File Transfer. Don’t automatically load 'xep_0106', # JID Escaping 'xep_0107', # User Mood 'xep_0108', # User Activity @@ -51,6 +54,7 @@ __all__ = [ 'xep_0128', # Extended Service Discovery 'xep_0131', # Standard Headers and Internet Metadata 'xep_0133', # Service Administration +# 'xep_0138', # Stream Compression. Broken atm 'xep_0152', # Reachability Addresses 'xep_0153', # vCard-Based Avatars 'xep_0163', # Personal Eventing Protocol @@ -69,27 +73,34 @@ __all__ = [ 'xep_0224', # Attention 'xep_0231', # Bits of Binary 'xep_0235', # OAuth Over XMPP - 'xep_0242', # XMPP Client Compliance 2009 +# 'xep_0242', # XMPP Client Compliance 2009. Don’t automatically load 'xep_0249', # Direct MUC Invitations 'xep_0256', # Last Activity in Presence 'xep_0257', # Client Certificate Management for SASL EXTERNAL 'xep_0258', # Security Labels in XMPP - 'xep_0270', # XMPP Compliance Suites 2010 +# 'xep_0270', # XMPP Compliance Suites 2010. Don’t automatically load 'xep_0279', # Server IP Check 'xep_0280', # Message Carbons 'xep_0297', # Stanza Forwarding - 'xep_0302', # XMPP Compliance Suites 2012 + 'xep_0300', # Use of Cryptographic Hash Functions in XMPP +# 'xep_0302', # XMPP Compliance Suites 2012. Don’t automatically load 'xep_0308', # Last Message Correction 'xep_0313', # Message Archive Management 'xep_0319', # Last User Interaction in Presence - 'xep_0323', # IoT Systems Sensor Data - 'xep_0325', # IoT Systems Control +# 'xep_0323', # IoT Systems Sensor Data. Don’t automatically load +# 'xep_0325', # IoT Systems Control. Don’t automatically load 'xep_0332', # HTTP Over XMPP Transport + 'xep_0333', # Chat Markers + 'xep_0334', # Message Processing Hints + 'xep_0335', # JSON Containers + 'xep_0352', # Client State Indication 'xep_0353', # Jingle Message Initiation 'xep_0359', # Unique and Stable Stanza IDs 'xep_0363', # HTTP File Upload 'xep_0369', # MIX-CORE 'xep_0377', # Spam reporting + 'xep_0380', # Explicit Message Encryption + 'xep_0394', # Message Markup 'xep_0403', # MIX-Presence 'xep_0404', # MIX-Anon 'xep_0405', # MIX-PAM From 6db5bb65d337ebc0813a46420dbd8c7dacec74d8 Mon Sep 17 00:00:00 2001 From: Emmanuel Gil Peyrot Date: Sat, 5 Dec 2020 01:00:52 +0100 Subject: [PATCH 4/5] XEP-0300: Fix tests --- slixmpp/plugins/xep_0300/hash.py | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/slixmpp/plugins/xep_0300/hash.py b/slixmpp/plugins/xep_0300/hash.py index 6095671d..75252d0c 100644 --- a/slixmpp/plugins/xep_0300/hash.py +++ b/slixmpp/plugins/xep_0300/hash.py @@ -39,25 +39,22 @@ class XEP_0300(BasePlugin): 'sha-1': hashlib.sha1, 'sha-256': hashlib.sha256, 'sha-512': hashlib.sha512, - 'sha3-256': lambda: hashlib.sha3_256(), - 'sha3-512': lambda: hashlib.sha3_512(), + 'sha3-256': hashlib.sha3_256, + 'sha3-512': hashlib.sha3_512, 'BLAKE2b256': lambda: hashlib.blake2b(digest_size=32), 'BLAKE2b512': lambda: hashlib.blake2b(digest_size=64), } + def __init__(self, *args, **kwargs): + super().__init__(*args, **kwargs) + self.enabled_hashes = [] + def plugin_init(self): namespace = 'urn:xmpp:hash-function-text-names:%s' - self.enabled_hashes = [] + self.enabled_hashes.clear() for algo in self._hashlib_function: if getattr(self, 'enable_' + algo, False): - # XXX: this is a hack for Python 3.5 or below, which - # don’t support sha3 or blake2b… - try: - self._hashlib_function[algo]() - except AttributeError: - log.warn('Algorithm %s unavailable, disabling.', algo) - else: - self.enabled_hashes.append(namespace % algo) + self.enabled_hashes.append(namespace % algo) def session_bind(self, jid): self.xmpp['xep_0030'].add_feature(Hash.namespace) @@ -68,6 +65,7 @@ class XEP_0300(BasePlugin): def plugin_end(self): for namespace in self.enabled_hashes: self.xmpp['xep_0030'].del_feature(namespace) + self.enabled_hashes.clear() self.xmpp['xep_0030'].del_feature(feature=Hash.namespace) From 684247b375cb629c6a63944e12a42dd9ae59ac7c Mon Sep 17 00:00:00 2001 From: Emmanuel Gil Peyrot Date: Sat, 5 Dec 2020 01:05:16 +0100 Subject: [PATCH 5/5] XEP-0352: Only enable the feature on ClientXMPP --- slixmpp/plugins/xep_0352/csi.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/slixmpp/plugins/xep_0352/csi.py b/slixmpp/plugins/xep_0352/csi.py index 93295b84..21bfe371 100644 --- a/slixmpp/plugins/xep_0352/csi.py +++ b/slixmpp/plugins/xep_0352/csi.py @@ -8,6 +8,7 @@ import logging +from slixmpp import ClientXMPP from slixmpp.stanza import StreamFeatures from slixmpp.xmlstream import register_stanza_plugin from slixmpp.plugins.base import BasePlugin @@ -40,17 +41,19 @@ class XEP_0352(BasePlugin): self.xmpp.register_stanza(stanza.Active) self.xmpp.register_stanza(stanza.Inactive) - self.xmpp.register_feature('csi', - self._handle_csi_feature, - restart=False, - order=self.order) + if isinstance(self.xmpp, ClientXMPP): + self.xmpp.register_feature('csi', + self._handle_csi_feature, + restart=False, + order=self.order) def plugin_end(self): if self.xmpp.is_component: return - self.xmpp.unregister_feature('csi', self.order) + if isinstance(self.xmpp, ClientXMPP): + self.xmpp.unregister_feature('csi', self.order) self.xmpp.remove_stanza(stanza.Active) self.xmpp.remove_stanza(stanza.Inactive)