From d50d996c68ad82974b8384320bbe9cc875b17d56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maxime=20=E2=80=9Cpep=E2=80=9D=20Buquet?= Date: Tue, 16 Jul 2019 11:26:54 +0200 Subject: [PATCH] xmlstream/stanzabase: remove unused interfaces and types attributes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These are already on each stanza, and were not applicable to all stanzas anyway. Signed-off-by: Maxime “pep” Buquet --- slixmpp/xmlstream/stanzabase.py | 8 -------- tests/test_stanza_base.py | 8 -------- 2 files changed, 16 deletions(-) diff --git a/slixmpp/xmlstream/stanzabase.py b/slixmpp/xmlstream/stanzabase.py index 1c000b69..3e45f613 100644 --- a/slixmpp/xmlstream/stanzabase.py +++ b/slixmpp/xmlstream/stanzabase.py @@ -1374,14 +1374,6 @@ class StanzaBase(ElementBase): #: The default XMPP client namespace namespace = 'jabber:client' - #: There is a small set of attributes which apply to all XMPP stanzas: - #: the stanza type, the to and from JIDs, the stanza ID, and, especially - #: in the case of an Iq stanza, a payload. - interfaces = {'type', 'to', 'from', 'id', 'payload'} - - #: A basic set of allowed values for the ``'type'`` interface. - types = {'get', 'set', 'error', None, 'unavailable', 'normal', 'chat'} - def __init__(self, stream=None, xml=None, stype=None, sto=None, sfrom=None, sid=None, parent=None): self.stream = stream diff --git a/tests/test_stanza_base.py b/tests/test_stanza_base.py index 35fa5e99..55554aa9 100644 --- a/tests/test_stanza_base.py +++ b/tests/test_stanza_base.py @@ -68,13 +68,5 @@ class TestStanzaBase(SlixTest): self.assertTrue(stanza['payload'] == [], "Stanza reply did not empty stanza payload.") - def testError(self): - """Test marking a stanza as an error.""" - stanza = StanzaBase() - stanza['type'] = 'get' - stanza.error() - self.assertTrue(stanza['type'] == 'error', - "Stanza type is not 'error' after calling error()") - suite = unittest.TestLoader().loadTestsFromTestCase(TestStanzaBase)