pep/xmpp-rs-mirror
1
0
Fork 0
mirror of https://gitlab.com/xmpp-rs/xmpp-rs.git synced 2024-07-12 22:21:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

message_correct: Check for unwanted attributes.

Browse source
This commit is contained in:
Emmanuel Gil Peyrot 2017-05-24 21:42:29 +01:00
parent 453a3635fd
commit 6952f3adfc
1 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/message_correct.rs
View file

@ -27,6 +27,11 @@ impl TryFrom<Element> for Replace {
for _ in elem.children() {
return Err(Error::ParseError("Unknown child in replace element."));
}
for (attr, _) in elem.attrs() {
if attr != "id" {
return Err(Error::ParseError("Unknown attribute in replace element."));
}
}
let id = get_attr!(elem, "id", required);
Ok(Replace { id })
}
@ -36,7 +41,7 @@ impl Into<Element> for Replace {
fn into(self) -> Element {
Element::builder("replace")
.ns(ns::MESSAGE_CORRECT)
.attr("id", self.id.clone())
.attr("id", self.id)
.build()
}
}
@ -51,6 +56,17 @@ mod tests {
Replace::try_from(elem).unwrap();
}
#[test]
fn test_invalid_attribute() {
let elem: Element = "<replace xmlns='urn:xmpp:message-correct:0' coucou=''/>".parse().unwrap();
let error = Replace::try_from(elem).unwrap_err();
let message = match error {
Error::ParseError(string) => string,
_ => panic!(),
};
assert_eq!(message, "Unknown attribute in replace element.");
}
#[test]
fn test_invalid_child() {
let elem: Element = "<replace xmlns='urn:xmpp:message-correct:0'><coucou/></replace>".parse().unwrap();