From dd80f55c5f5bcdfa52e3a2da9bbe262c64efa9d4 Mon Sep 17 00:00:00 2001
From: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Date: Tue, 26 Feb 2019 19:43:29 +0100
Subject: [PATCH] =?UTF-8?q?disco:=20Add=20constructors=20for=20Identity,?=
 =?UTF-8?q?=20and=20fix=20Feature=E2=80=99s.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/disco.rs | 34 ++++++++++++++++++++++++++++++++--
 1 file changed, 32 insertions(+), 2 deletions(-)

diff --git a/src/disco.rs b/src/disco.rs
index 0acdcb8..b958cce 100644
--- a/src/disco.rs
+++ b/src/disco.rs
@@ -36,9 +36,9 @@ attributes: [
 
 impl Feature {
     /// Create a new `<feature/>` with the according `@var`.
-    pub fn new(var: &str) -> Feature {
+    pub fn new<S: Into<String>>(var: S) -> Feature {
         Feature {
-            var: String::from(var)
+            var: var.into(),
         }
     }
 }
@@ -59,6 +59,36 @@ pub struct Identity {
     pub name: Option<String>,
 }
 
+impl Identity {
+    /// Create a new `<identity/>`.
+    pub fn new<C, T, L, N>(category: C, type_: T, lang: L, name: N) -> Identity
+    where C: Into<String>,
+          T: Into<String>,
+          L: Into<String>,
+          N: Into<String>,
+    {
+        Identity {
+            category: category.into(),
+            type_: type_.into(),
+            lang: Some(lang.into()),
+            name: Some(name.into()),
+        }
+    }
+
+    /// Create a new `<identity/>` without a name.
+    pub fn new_anonymous<C, T, L, N>(category: C, type_: T) -> Identity
+    where C: Into<String>,
+          T: Into<String>,
+    {
+        Identity {
+            category: category.into(),
+            type_: type_.into(),
+            lang: None,
+            name: None,
+        }
+    }
+}
+
 impl TryFrom<Element> for Identity {
     type Err = Error;