From f68826057b094969e1ab1a45bfca0991bf2b1f11 Mon Sep 17 00:00:00 2001 From: Emmanuel Gil Peyrot Date: Thu, 21 Feb 2019 21:06:23 +0100 Subject: [PATCH] Fix clippy lints --- src/convert.rs | 2 +- src/element.rs | 4 ++-- src/namespace_set.rs | 6 +++--- src/node.rs | 4 +--- 4 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/convert.rs b/src/convert.rs index 5340732..7c6d314 100644 --- a/src/convert.rs +++ b/src/convert.rs @@ -44,7 +44,7 @@ impl<'a> IntoAttributeValue for &'a str { impl IntoAttributeValue for Option { fn into_attribute_value(self) -> Option { - self.and_then(|t| t.into_attribute_value()) + self.and_then(IntoAttributeValue::into_attribute_value) } } diff --git a/src/element.rs b/src/element.rs index 5db7727..a94c1ce 100644 --- a/src/element.rs +++ b/src/element.rs @@ -102,8 +102,8 @@ impl Element { Element { prefix, name, namespaces: Rc::new(namespaces.into()), - attributes: attributes, - children: children, + attributes, + children, } } diff --git a/src/namespace_set.rs b/src/namespace_set.rs index 7671062..57d3156 100644 --- a/src/namespace_set.rs +++ b/src/namespace_set.rs @@ -58,7 +58,7 @@ impl From, String>> for NamespaceSet { fn from(namespaces: BTreeMap, String>) -> Self { NamespaceSet { parent: RefCell::new(None), - namespaces: namespaces, + namespaces, } } } @@ -79,7 +79,7 @@ impl From for NamespaceSet { NamespaceSet { parent: RefCell::new(None), - namespaces: namespaces, + namespaces, } } } @@ -92,7 +92,7 @@ impl From<(Option, String)> for NamespaceSet { NamespaceSet { parent: RefCell::new(None), - namespaces: namespaces, + namespaces, } } } diff --git a/src/node.rs b/src/node.rs index 7fe5dda..b136dbd 100644 --- a/src/node.rs +++ b/src/node.rs @@ -165,13 +165,11 @@ impl Node { Node::Element(ref elmt) => elmt.write_to_inner(writer)?, Node::Text(ref s) => { writer.write_event(Event::Text(BytesText::from_plain_str(s)))?; - () }, Node::Comment(ref s) => { writer.write_event(Event::Comment(BytesText::from_plain_str(s)))?; - () }, - }; + } Ok(()) }