xmpp-rs-mirror/xmpp
Jonas Schäfer 80efd2eb19 Ignore missing disco#info feature in disco#info responses
xmpp-rs normally has the stance to get buggy implementations fixed
rather than dropping checks. In this particular case I think this is not
a good use of resources:

- The disco#info feature var conveys no actual information:
  If an implementation replies properly to a disco#info query, it is
  already implied that it supports the protocol.

- There are broken server implementations out there.
  A lot of them (all recent (>= 0.10 && < 0.13 AFAICT) Prosody IM
  instances). At this point in time, xmpp-rs is unable to query
  disco#info from MUCs hosted on such prosody versions, except by
  workarounds (such as the one removed in this diff).

- XEP-0030 now features a note which reads:

  > Note: Some entities are known not to advertise the
  > `http://jabber.org/protocol/disco#info` feature within their
  > responses, contrary to this specification. Entities receiving
  > otherwise valid responses which do not include this feature SHOULD
  > infer the support.

The case would be different if there were no (deployed) implementations
which had this bug or if the bug actually had an effect on clients.
Especially the latter is not the case though, as pointed out above.

Hence, I conclude that this check is overly pedantic and the resources
(time, emotional energy of dealing with bugs, punching patches through
to stable distributions, etc. etc.) spent on getting this fixed would
be better invested elsewhere.

In addition, the workaround is extremely ugly and, even in the xmpp-rs
implementation, has no test coverage. Without test coverage of such an
implementation, it is bound to break in funny ways when xmpp-rs changes
the strings of its error messages (which is something one might do even
outside a breaking release).
2024-06-16 10:52:51 +02:00
..
examples jid: rewrite public types 2024-04-15 18:21:24 +02:00
src Ignore missing disco#info feature in disco#info responses 2024-06-16 10:52:51 +02:00
Cargo.toml Add serde feature for xmpp crate 2024-06-05 11:20:33 +02:00
ChangeLog Add serde feature for xmpp crate 2024-06-05 11:20:33 +02:00
LICENSE Remove the -rs suffix of jid, minidom and xmpp 2020-06-22 02:17:32 +02:00
README.md Finish removing 'rs' suffix in libs 2020-07-15 10:49:50 +02:00

xmpp

What's this?

A very much WIP rust XMPP library with the goals of being type-safe and well-tested.

Contact

There is an XMPP MUC for the discussion of this library, feel free to join! :)

chat@xmpp.rs

License

Mozilla Public License 2 (MPL2). See the LICENSE file.