pep/xmpp-rs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

turns out i was wrong and clippy was right, all hail clippy

Browse source
This commit is contained in:
lumi 2017-05-22 18:49:24 +02:00
parent dbcbe7cd9b
commit 3341d7e692
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/element.rs
View file

@ -600,9 +600,8 @@ pub struct Children<'a> {
impl<'a> Iterator for Children<'a> { impl<'a> Iterator for Children<'a> {
type Item = &'a Element; type Item = &'a Element;
#[cfg_attr(feature = "cargo-clippy", allow(while_let_on_iterator))]
fn next(&mut self) -> Option<&'a Element> { fn next(&mut self) -> Option<&'a Element> {
while let Some(item) = self.iter.next() { for item in &mut self.iter {
if let Node::Element(ref child) = *item { if let Node::Element(ref child) = *item {
return Some(child); return Some(child);
} }
@ -619,9 +618,8 @@ pub struct ChildrenMut<'a> {
impl<'a> Iterator for ChildrenMut<'a> { impl<'a> Iterator for ChildrenMut<'a> {
type Item = &'a mut Element; type Item = &'a mut Element;
#[cfg_attr(feature = "cargo-clippy", allow(while_let_on_iterator))]
fn next(&mut self) -> Option<&'a mut Element> { fn next(&mut self) -> Option<&'a mut Element> {
while let Some(item) = self.iter.next() { for item in &mut self.iter {
if let Node::Element(ref mut child) = *item { if let Node::Element(ref mut child) = *item {
return Some(child); return Some(child);
} }
@ -638,9 +636,8 @@ pub struct Texts<'a> {
impl<'a> Iterator for Texts<'a> { impl<'a> Iterator for Texts<'a> {
type Item = &'a str; type Item = &'a str;
#[cfg_attr(feature = "cargo-clippy", allow(while_let_on_iterator))]
fn next(&mut self) -> Option<&'a str> { fn next(&mut self) -> Option<&'a str> {
while let Some(item) = self.iter.next() { for item in &mut self.iter {
if let Node::Text(ref child) = *item { if let Node::Text(ref child) = *item {
return Some(child); return Some(child);
} }
@ -657,9 +654,8 @@ pub struct TextsMut<'a> {
impl<'a> Iterator for TextsMut<'a> { impl<'a> Iterator for TextsMut<'a> {
type Item = &'a mut String; type Item = &'a mut String;
#[cfg_attr(feature = "cargo-clippy", allow(while_let_on_iterator))]
fn next(&mut self) -> Option<&'a mut String> { fn next(&mut self) -> Option<&'a mut String> {
while let Some(item) = self.iter.next() { for item in &mut self.iter {
if let Node::Text(ref mut child) = *item { if let Node::Text(ref mut child) = *item {
return Some(child); return Some(child);
} }