pep/xmpp-rs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

message: Remove extra clones, and simplify Into<Element>.

Browse source
This commit is contained in:
Emmanuel Gil Peyrot 2017-05-24 21:40:11 +01:00
parent 8182213666
commit 453a3635fd
1 changed files with 31 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/message.rs
View file

@ -97,7 +97,7 @@ impl Into<Element> for MessagePayload {
MessagePayload::StanzaId(stanza_id) => stanza_id.into(), MessagePayload::StanzaId(stanza_id) => stanza_id.into(),
MessagePayload::MamResult(result) => result.into(), MessagePayload::MamResult(result) => result.into(),
MessagePayload::Unknown(elem) => elem.clone(), MessagePayload::Unknown(elem) => elem,
} }
} }
} }
@ -221,12 +221,12 @@ impl TryFrom<Element> for Message {
impl Into<Element> for Message { impl Into<Element> for Message {
fn into(self) -> Element { fn into(self) -> Element {
let mut stanza = Element::builder("message") Element::builder("message")
.ns(ns::JABBER_CLIENT) .ns(ns::JABBER_CLIENT)
.attr("from", self.from.clone().and_then(|value| Some(String::from(value)))) .attr("from", self.from.and_then(|value| Some(String::from(value))))
.attr("to", self.to.clone().and_then(|value| Some(String::from(value)))) .attr("to", self.to.and_then(|value| Some(String::from(value))))
.attr("id", self.id.clone()) .attr("id", self.id)
.attr("type", self.type_.clone()) .attr("type", self.type_)
.append(self.subjects.iter() .append(self.subjects.iter()
.map(|(lang, subject)| { .map(|(lang, subject)| {
Element::builder("subject") Element::builder("subject")
@ -235,7 +235,7 @@ impl Into<Element> for Message {
"" => None, "" => None,
lang => Some(lang), lang => Some(lang),
}) })
.append(subject.clone()) .append(subject)
.build() }) .build() })
.collect::<Vec<_>>()) .collect::<Vec<_>>())
.append(self.bodies.iter() .append(self.bodies.iter()
@ -246,14 +246,11 @@ impl Into<Element> for Message {
"" => None, "" => None,
lang => Some(lang), lang => Some(lang),
}) })
.append(body.clone()) .append(body)
.build() }) .build() })
.collect::<Vec<_>>()) .collect::<Vec<_>>())
.build(); .append(self.payloads)
for child in self.payloads.clone() { .build()
stanza.append_child(child);
}
stanza
} }
} }