pep/xmpp-rs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tokio-xmpp: Remove workaround for unknown broken server

Browse source 
This is so we can find and fix the server, instead of cargo culting this
workaround forever.
This commit is contained in:
Emmanuel Gil Peyrot 2020-12-26 16:25:32 +01:00
parent 2f570fcabe
commit e1ff9da681
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tokio-xmpp/src/client/auth.rs
View file

@ -54,9 +54,14 @@ pub async fn auth<S: AsyncRead + AsyncWrite + Unpin>(
return Ok(stream.into_inner()); return Ok(stream.into_inner());
} else if let Ok(failure) = Failure::try_from(stanza.clone()) { } else if let Ok(failure) = Failure::try_from(stanza.clone()) {
return Err(Error::Auth(AuthError::Fail(failure.defined_condition))); return Err(Error::Auth(AuthError::Fail(failure.defined_condition)));
// TODO: This code was needed for compatibility with some broken server,
// but it’s been forgotten which. It is currently commented out so that we
// can find it and fix the server software instead.
/*
} else if stanza.name() == "failure" { } else if stanza.name() == "failure" {
// Workaround for https://gitlab.com/xmpp-rs/xmpp-parsers/merge_requests/1 // Workaround for https://gitlab.com/xmpp-rs/xmpp-parsers/merge_requests/1
return Err(Error::Auth(AuthError::Sasl("failure".to_string()))); return Err(Error::Auth(AuthError::Sasl("failure".to_string())));
*/
} else { } else {
// ignore and loop // ignore and loop
} }