Commit graph

67 commits

Author SHA1 Message Date
Bastien Orivel
f87e2442d4 Use a BTreeMap<String, String> instead of a Vec<Attribute> to store attributes
This way we don't need to reimplement PartialEq for Element. It's also
way easier to get an attribute by name as we don't need to iterate over
every attribute to see if it exists.

The only side effect is that now, in the Debug output, attributes are
automatically sorted by names instead of being sorted by insertion
order.

Fixes #4
2017-04-26 23:44:58 +02:00
lumi
c6f9cc485f Merge branch 'Eijebong/minidom-rs-fix_namespaced_attributes'
# Conflicts:
#	src/tests.rs
2017-04-26 01:02:17 +02:00
Eijebong
0d0c4b76eb Fix the PartialEq implementation for Element
The order of attributes in an `Element` doesn't matter anymore.
`<elem a="b" c="d" />` and `<elem c="d" a="b" />` are now correctly
considered equal.

For that I had to derive `PartialOrd` and `Ord` for `Attribute`.
This allows us to sort cloned vectors of `Attribute` in the `PartialEq`
implementation and compare them instead of the struct `attributes`.

Fixes #3
2017-04-24 21:15:53 +02:00
Eijebong
6f0e88b25b Correctly add namespaced attributes to elements
Instead of adding the local_name of an attribute, if a prefix exists,
add prefix:local_name to allow users to retrieve it via the namespaced
key name.

For example, with this XML:
```
<?xml version="1.0" encoding="utf-8"?>
<root xml:lang="en" >
</root>
```

`root.attr("xml:lang").unwrap()` will now correctly return "en".
`root.attr("lang")` will not retrieve "xml:lang" value anymore.

This is a breaking change.

Fixes #2
2017-04-24 18:19:50 +02:00
Emmanuel Gil Peyrot
9af7d252d7 auto-close elements with no child 2017-04-01 13:34:08 +01:00
Emmanuel Gil Peyrot
f301f2cb10 make Debug on Element return valid XML 2017-04-01 13:34:08 +01:00
lumi
7c04aff416 overhauling the library, made tests pass 2017-03-08 20:34:17 +01:00
lumi
112b3fa0c8 added documentation url and fixed a dumb mistake 2017-02-25 15:43:56 +01:00
lumi
9a00c998ae add a test for an issue with namespace propagation 2017-02-25 00:10:18 +01:00
lumi
0a45a6993e document all the things! 2017-02-21 15:46:06 +01:00
lumi
e0b35477cd add ElementBuilder::text 2017-02-20 23:58:44 +01:00
lumi
41e1cf2654 added has_child, fixed some warnings 2017-02-20 02:04:45 +01:00
lumi
663eba6754 implemented text, get_child and get_child_mut; added and updated some tests 2017-02-19 23:42:31 +01:00
lumi
2d97e2d5d9 put Attribute into its own module, take into account prefixes when determining namespaces 2017-02-19 23:29:19 +01:00
lumi
8663a14040 lots of fixes and simplifications of the API 2017-02-19 23:15:43 +01:00
lumi
fda38ff242 add child iterators and fix up some of the tests, which still do not pass (yet) 2017-02-19 21:45:51 +01:00
lumi
28045361f3 initial commit 2017-02-19 20:46:44 +01:00